• Marek Vasut's avatar
    i2c: mxs: Fix misuse init_completion · 85de7fac
    Marek Vasut authored
    The init_completion() call does reinit not only the variable carrying
    the flag that the completion finished, but also initialized the
    waitqueue associated with the completion. On the contrary, the
    INIT_COMPLETION() call only reinits the flag.
    
    In case there was anything still stuck in the waitqueue, subsequent call
    to init_completion() would be able to create possible race condition. This
    patch uses the proper function and moves init_completion() into .probe() call
    of the driver, to be issued only once.
    
    Note that such scenario is impossible, since two threads can never enter the
    mxs_i2c_xfer_msg(), since whole this section is protected by mutex in I2C core.
    This by no means allows this issue to exit though.
    Signed-off-by: default avatarMarek Vasut <marex@denx.de>
    Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
    85de7fac
i2c-mxs.c 14.3 KB