• Caleb Crome's avatar
    ASoC: fsl_ssi: add CCSR_SSI_SOR to volatile register list · 3cc6185b
    Caleb Crome authored
    The CCSR_SSI_SOR is a register that clears the TX and/or the RX fifo
    on the i.MX SSI port.  The fsl_ssi_trigger writes this register in
    order to clear the fifo at trigger time.
    
    However, since the CCSR_SSI_SOR register is not in the volatile list,
    the caching mechanism prevented the register write in the trigger
    function.  This caused the fifo to not be cleared (because the value
    was unchanged from the last time the register was written), and thus
    causes the channels in both TDM or simple I2S mode to slip and be in
    the wrong time slots on SSI restart.
    
    This has gone unnoticed for so long because with simple stereo mode,
    the consequence is that left and right are swapped, which isn't that
    noticeable.  However, it's catestrophic in some systems that
    require the channels to be in the right slots.
    Signed-off-by: default avatarCaleb Crome <caleb@crome.org>
    Suggested-by: default avatarArnaud Mouiche <arnaud.mouiche@invoxia.com>
    Reviewed-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
    Acked-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    3cc6185b
fsl_ssi.c 46 KB