• Hans de Goede's avatar
    [media] pwc: Replace private buffer management code with videobuf2 · 885fe18f
    Hans de Goede authored
    Looking at the pwc buffer management code has made it clear to me it needed
    some serious fixing. Not only was there a ton of code duplication even
    internally to pwc (read and mmap wait for frame code was duplicated), the
    code also was outright buggy. With the worst offender being dqbuf, which
    just round robin returned all the mmap buffers, without paying any attention
    to them being queued by the app with qbuf or not. And qbuf itself was a noop.
    
    So I set out to fix this and already had some cleanups in place when
    I read Jonathan Corbet's lwn article on videobuf2, this inspired me to just
    rip out the buffer management code and replace it with videobuf2, greatly
    reducing the amount of code, and fixing all bugs in one go:
    
    Many thanks to Jonathan for the timely article on this !
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    885fe18f
pwc-if.c 44.5 KB