• Ilya Dryomov's avatar
    libceph: ceph_build_auth() doesn't need ceph_auth_build_hello() · 464691bd
    Ilya Dryomov authored
    A static bug finder (EBA) on Linux 4.7:
    
        Double lock in net/ceph/auth.c
        second lock at 108: mutex_lock(& ac->mutex); [ceph_auth_build_hello]
        after calling from 263: ret = ceph_auth_build_hello(ac, msg_buf, msg_len);
        if ! ac->protocol -> true at 262
        first lock at 261: mutex_lock(& ac->mutex); [ceph_build_auth]
    
    ceph_auth_build_hello() is never called, because the protocol is always
    initialized, whether we are checking existing tickets (in delayed_work())
    or getting new ones after invalidation (in invalidate_authorizer()).
    Reported-by: default avatarIago Abal <iari@itu.dk>
    Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
    464691bd
auth.c 7.42 KB