• Konstantin Khlebnikov's avatar
    ipc/msg: fix race around refcount · 91182754
    Konstantin Khlebnikov authored
    In older kernels (before v3.10) ipc_rcu_hdr->refcount was non-atomic int.
    There was possuble double-free bug: do_msgsnd() calls ipc_rcu_putref() under
    msq->q_perm->lock and RCU, while freequeue() calls it while it holds only
    'rw_mutex', so there is no sinchronization between them. Two function
    decrements '2' non-atomically, they both can get '0' as result.
    
    do_msgsnd()					freequeue()
    
    msq = msg_lock_check(ns, msqid);
    ...
    ipc_rcu_getref(msq);
    msg_unlock(msq);
    schedule();
    						(caller locks spinlock)
    						expunge_all(msq, -EIDRM);
    						ss_wakeup(&msq->q_senders, 1);
    						msg_rmid(ns, msq);
    						msg_unlock(msq);
    ipc_lock_by_ptr(&msq->q_perm);
    ipc_rcu_putref(msq);				ipc_rcu_putref(msq);
    < both may get get --(...)->refcount == 0 >
    
    This patch locks ipc_lock and RCU around ipc_rcu_putref in freequeue.
    ( RCU protects memory for spin_unlock() )
    
    Similar bugs might be in other users of ipc_rcu_putref().
    
    In the mainline this has been fixed in v3.10 indirectly in commmit
    6062a8dc
    ("ipc,sem: fine grained locking for semtimedop") by Rik van Riel.
    That commit optimized locking and converted refcount into atomic.
    
    I'm not sure that anybody should care about this bug: it's very-very unlikely
    and no longer exists in actual mainline. I've found this just by looking into
    the code, probably this never happens in real life.
    Signed-off-by: default avatarKonstantin Khlebnikov <k.khlebnikov@samsung.com>
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    91182754
msg.c 20.9 KB