• Huang Shijie's avatar
    mxs-dma : rewrite the last parameter of mxs_dma_prep_slave_sg() · 921de864
    Huang Shijie authored
    [1] Background :
        The GPMI does ECC read page operation with a DMA chain consist of three DMA
        Command Structures. The middle one of the chain is used to enable the BCH,
        and read out the NAND page.
    
        The WAIT4END(wait for command end) is a comunication signal between
        the GPMI and MXS-DMA.
    
    [2] The current DMA code sets the WAIT4END bit at the last one, such as:
    
        +-----+               +-----+                      +-----+
        | cmd | ------------> | cmd | ------------------>  | cmd |
        +-----+               +-----+                      +-----+
                                                              ^
                                                              |
                                                              |
                                                         set WAIT4END here
    
        This chain works fine in the mx23/mx28.
    
    [3] But in the new GPMI version (used in MX50/MX60), the WAIT4END bit should
        be set not only at the last DMA Command Structure,
        but also at the middle one, such as:
    
        +-----+               +-----+                      +-----+
        | cmd | ------------> | cmd | ------------------>  | cmd |
        +-----+               +-----+                      +-----+
                                 ^                            ^
                                 |                            |
                                 |                            |
                            set WAIT4END here too        set WAIT4END here
    
        If we do not set WAIT4END, the BCH maybe stalls in "ECC reading page" state.
        In the next ECC write page operation, a DMA-timeout occurs.
        This has been catched in the MX6Q board.
    
    [4] In order to fix the bug, rewrite the last parameter of mxs_dma_prep_slave_sg(),
        and use the dma_ctrl_flags:
        ---------------------------------------------------------
          DMA_PREP_INTERRUPT : append a new DMA Command Structrue.
          DMA_CTRL_ACK       : set the WAIT4END bit for this DMA Command Structure.
        ---------------------------------------------------------
    
    [5] changes to the relative drivers:
        <1> For mxs-mmc driver, just use the new flags, do not change any logic.
        <2> For gpmi-nand driver, and use the new flags to set the DMA
            chain, especially for ecc read page.
    Acked-by: default avatarShawn Guo <shawn.guo@linaro.org>
    Signed-off-by: default avatarHuang Shijie <b32955@freescale.com>
    Acked-by: default avatarVinod Koul <vinod.koul@linux.intel.com>
    Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
    921de864
mxs-dma.c 18.4 KB