• Harvey Harrison's avatar
    USB: cp2101.c fix sparse signedness mismatch warnings · b2bdd1f5
    Harvey Harrison authored
    The get/set 2101_config helpers take an unsigned int rather than an
    int.  It is safe to change these in each case and may even produce
    better code as it will be an unsigned divide rather than a signed
    divide in places.  All other manipulation was setting/masking bits
    which will not be affected by the sign change.
    
    Fixes the following sparse warnings:
    drivers/usb/serial/cp2101.c:378:44: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:378:44:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:378:44:    got int *<noident>
    drivers/usb/serial/cp2101.c:388:40: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:388:40:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:388:40:    got int *<noident>
    drivers/usb/serial/cp2101.c:413:42: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:413:42:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:413:42:    got int *<noident>
    drivers/usb/serial/cp2101.c:421:42: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:421:42:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:421:42:    got int *<noident>
    drivers/usb/serial/cp2101.c:444:42: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:444:42:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:444:42:    got int *<noident>
    drivers/usb/serial/cp2101.c:451:42: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:451:42:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:451:42:    got int *<noident>
    drivers/usb/serial/cp2101.c:458:42: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:458:42:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:458:42:    got int *<noident>
    drivers/usb/serial/cp2101.c:471:42: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:471:42:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:471:42:    got int *<noident>
    drivers/usb/serial/cp2101.c:481:42: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:481:42:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:481:42:    got int *<noident>
    drivers/usb/serial/cp2101.c:561:41: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:561:41:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:561:41:    got int *<noident>
    drivers/usb/serial/cp2101.c:591:45: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:591:45:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:591:45:    got int *<noident>
    drivers/usb/serial/cp2101.c:597:41: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:597:41:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:597:41:    got int *<noident>
    drivers/usb/serial/cp2101.c:608:45: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:608:45:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:608:45:    got int *<noident>
    drivers/usb/serial/cp2101.c:614:41: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:614:41:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:614:41:    got int *<noident>
    drivers/usb/serial/cp2101.c:623:45: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:623:45:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:623:45:    got int *<noident>
    drivers/usb/serial/cp2101.c:680:50: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:680:50:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:680:50:    got int *<noident>
    drivers/usb/serial/cp2101.c:690:43: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:690:43:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:690:43:    got int *<noident>
    drivers/usb/serial/cp2101.c:715:41: warning: incorrect type in argument 3 (different signedness)
    drivers/usb/serial/cp2101.c:715:41:    expected unsigned int *data
    drivers/usb/serial/cp2101.c:715:41:    got int *<noident>
    Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    b2bdd1f5
cp2101.c 21 KB