• Rusty Russell's avatar
    cpumask: remove dangerous CPU_MASK_ALL_PTR, &CPU_MASK_ALL.: mips · 51c870a2
    Rusty Russell authored
    (Thanks to Al Viro for reminding me of this, via Ingo)
    
    CPU_MASK_ALL is the (deprecated) "all bits set" cpumask, defined as so:
    
    	#define CPU_MASK_ALL (cpumask_t) { { ... } }
    
    Taking the address of such a temporary is questionable at best,
    unfortunately 321a8e9d (cpumask: add CPU_MASK_ALL_PTR macro) added
    CPU_MASK_ALL_PTR:
    
    	#define CPU_MASK_ALL_PTR (&CPU_MASK_ALL)
    
    Which formalizes this practice.  One day gcc could bite us over this
    usage (though we seem to have gotten away with it so far).
    
    So replace everywhere which used &CPU_MASK_ALL or CPU_MASK_ALL_PTR
    with the modern "cpu_all_mask" (a real struct cpumask *), and remove
    CPU_MASK_ALL_PTR altogether.
    Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
    Acked-by: default avatarIngo Molnar <mingo@elte.hu>
    Reported-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    Cc: Mike Travis <travis@sgi.com>
    51c870a2
time.c 4.94 KB