• Jackie Li's avatar
    drm/i915: Add HuC firmware size related restriction for Gen9 and CNL A0 · 96c83d35
    Jackie Li authored
    On CNL A0 and Gen9, there's a hardware restriction that requires the
    available GuC WOPCM size to be larger than or equal to HuC firmware size.
    
    This patch adds new verification code to ensure the available GuC WOPCM
    size to be larger than or equal to HuC firmware size on both Gen9 and CNL
    A0.
    
    v6:
     - Extended HuC FW size check against GuC WOPCM size to all
       Gen9 and CNL A0 platforms
    
    v7:
     - Fixed patch format issues
    
    v8:
     - Renamed variables and functions to avoid ambiguity (Joonas)
     - Updated commit message and comments to be more comprehensive (Sagar)
    
    v9:
     - Moved code that is not related to restriction check into a separate
       patch and updated the commit message accordingly (Sagar/Michal)
     - Avoided to call uc_get_fw_size for better layer isolation (Michal)
    
    v10:
     - Shorten function names and reorganized size_check code to have clear
       isolation (Joonas)
     - Removed unnecessary comments (Joonas)
    
    v11:
     - Fixed logic error in size check (Michal)
    
    v12:
     - Add space between "HuC FW" and "(%uKiB)" in error message (Michal)
    
    v13:
     - Updated the ordering of s-o-b/cc/r-b tags (Sagar)
    
    BSpec: 10875
    Signed-off-by: default avatarJackie Li <yaodong.li@intel.com>
    Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
    Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
    Cc: John Spotswood <john.a.spotswood@intel.com>
    Cc: Jeff McGee <jeff.mcgee@intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com> (v8)
    Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com> (v11)
    Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> (v12)
    Reviewed-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Signed-off-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/1520987574-19351-4-git-send-email-yaodong.li@intel.com
    96c83d35
intel_wopcm.c 6.35 KB