• Aswath Govindraju's avatar
    spi: omap2-mcspi: Improve performance waiting for CHSTAT · 7b1d9681
    Aswath Govindraju authored
    This reverts commit 13d515c7 (spi: omap2-mcspi: Switch to
    readl_poll_timeout()).
    
    The amount of time spent polling for the MCSPI_CHSTAT bits to be set on
    AM335x-icev2 platform is less than 1us (about 0.6us) in most cases, with
    or without using DMA. So, in most cases the function need not sleep.
    Also, setting the sleep_usecs to zero would not be optimal here because
    ktime_add_us() used in readl_poll_timeout() is slower compared to the
    direct addition used after the revert. So, it is sub-optimal to use
    readl_poll_timeout in this case.
    
    When DMA is not enabled, this revert results in an increase of about 27%
    in throughput and decrease of about 20% in CPU usage. However, the CPU
    usage and throughput are almost the same when used with DMA.
    
    Therefore, fix this by reverting the commit which switched to using
    readl_poll_timeout().
    
    Fixes: 13d515c7 ("spi: omap2-mcspi: Switch to readl_poll_timeout()")
    Signed-off-by: default avatarAswath Govindraju <a-govindraju@ti.com>
    Link: https://lore.kernel.org/r/20200910122624.8769-1-a-govindraju@ti.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    7b1d9681
spi-omap2-mcspi.c 40.2 KB