• Mimi Zohar's avatar
    ima: fix ima_alloc_atfm() · 9a8d289f
    Mimi Zohar authored
    The patch 3bcced39: "ima: use ahash API for file hash
    calculation" from Feb 26, 2014, leads to the following static checker
    warning:
    
    security/integrity/ima/ima_crypto.c:204 ima_alloc_atfm()
             error: buffer overflow 'hash_algo_name' 17 <= 17
    
    Unlike shash tfm memory, which is allocated on initialization, the
    ahash tfm memory allocation is deferred until needed.
    
    This patch fixes the case where ima_ahash_tfm has not yet been
    allocated and the file's signature/hash xattr contains an invalid hash
    algorithm.  Although we can not verify the xattr, we still need to
    measure the file.  Use the default IMA hash algorithm.
    
    Changelog:
    - set valid algo before testing tfm - based on Dmitry's comment
    Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarMimi Zohar <zohar@linux.vnet.ibm.com>
    Signed-off-by: default avatarDmitry Kasatkin <d.kasatkin@samsung.com>
    9a8d289f
ima_crypto.c 13.9 KB