• Maciej W. Rozycki's avatar
    [PATCH] i386: apic_printk() used before initialized · 9b5dfd3d
    Maciej W. Rozycki authored
    Both detect_init_APIC() and init_apic_mappings() it's called from are
    invoked early, before the command line has been processed.  Therefore its
    meaningless to call apic_printk() from them as that depends on
    apic_verbosity which is initialized from the command line.
    
    I could move apic_verbosity initialization to parse_cmdline_early(), but I
    think that would be an overkill, the point being we are initerested in
    feedback from detect_init_APIC() anyway.  Without that it's hard to tell
    what's really going on as it's been the case with the recent report of the
    local APIC being non-functional despite the whole setup being apparently
    correct.  So I converted these calls to ordinary printk() invocations.  The
    init_apic_mappings() are less interesting, so I've made them output at the
    debug level.
    
    While at it I've made some obvious nearby formatting clean-up.
    Signed-off-by: default avatarMaciej W. Rozycki <macro@linux-mips.org>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    9b5dfd3d
apic.c 31.1 KB