• Hans de Goede's avatar
    Input: goodix - try to reset the controller if the i2c-test fails · 9e1f2d70
    Hans de Goede authored
    On some ACPI/x86 devices (where we use one of the ACPI IRQ pin access
    methods) the firmware is buggy, it does not properly reset the controller
    at boot, and we cannot communicate with it.
    
    Normally on ACPI/x86 devices we do not want to reset the controller at
    probe time since in some cases this causes the controller to loose its
    configuration and this is loaded into it by the system's firmware.
    So on these systems we leave the reset_controller_at_probe flag unset,
    even though we have a access to both the IRQ and reset pins and thus
    could reset it.
    
    In the case of the buggy firmware we have to reset the controller to
    actually be able to talk to it.
    
    This commit adds a special case for this, if the goodix_i2c_test() fails,
    and we have not reset the controller yet; and we do have a way to reset
    the controller then retry the i2c-test after resetting the controller.
    
    This fixes the driver failing at probe on ACPI/x86 systems with this
    firmware bug.
    Reported-and-tested-by: default avatarDmitry Mastykin <dmastykin@astralinux.ru>
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20200311191013.10826-2-hdegoede@redhat.comSigned-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
    9e1f2d70
goodix.c 34.2 KB