• Davidlohr Bueso's avatar
    Revert "locking/mutex: Complain upon mutex API misuse in IRQ contexts" · c571b72e
    Davidlohr Bueso authored
    This ended up causing some noise in places such as rxrpc running in softirq.
    
    The warning is misleading in this case as the mutex trylock and unlock
    operations are done within the same context; and therefore we need not
    worry about the PI-boosting issues that comes along with no single-owner
    lock guarantees.
    
    While we don't want to support this in mutexes, there is no way out of
    this yet; so lets get rid of the WARNs for now, as it is only fair to
    code that has historically relied on non-preemptible softirq guarantees.
    In addition, changing the lock type is also unviable: exclusive rwsems
    have the same issue (just not the WARN_ON) and counting semaphores
    would introduce a performance hit as mutexes are a lot more optimized.
    
    This reverts:
    
        a0855d24: ("locking/mutex: Complain upon mutex API misuse in IRQ contexts")
    
    Fixes: a0855d24: ("locking/mutex: Complain upon mutex API misuse in IRQ contexts")
    Signed-off-by: default avatarDavidlohr Bueso <dbueso@suse.de>
    Tested-by: default avatarDavid Howells <dhowells@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-afs@lists.infradead.org
    Cc: linux-fsdevel@vger.kernel.org
    Cc: will@kernel.org
    Link: https://lkml.kernel.org/r/20191210220523.28540-1-dave@stgolabs.netSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    c571b72e
mutex.c 37.5 KB