• Hugh Dickins's avatar
    mm: make swapoff more robust against soft dirty · 9f8bdb3f
    Hugh Dickins authored
    Both s390 and powerpc have hit the issue of swapoff hanging, when
    CONFIG_HAVE_ARCH_SOFT_DIRTY and CONFIG_MEM_SOFT_DIRTY ifdefs were not
    quite as x86_64 had them.  I think it would be much clearer if
    HAVE_ARCH_SOFT_DIRTY was just a Kconfig option set by architectures to
    determine whether the MEM_SOFT_DIRTY option should be offered, and the
    actual code depend upon CONFIG_MEM_SOFT_DIRTY alone.
    
    But won't embark on that change myself: instead make swapoff more
    robust, by using pte_swp_clear_soft_dirty() on each pte it encounters,
    without an explicit #ifdef CONFIG_MEM_SOFT_DIRTY.  That being a no-op,
    whether the bit in question is defined as 0 or the asm-generic fallback
    is used, unless soft dirty is fully turned on.
    
    Why "maybe" in maybe_same_pte()? Rename it pte_same_as_swp().
    Signed-off-by: default avatarHugh Dickins <hughd@google.com>
    Reviewed-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
    Acked-by: default avatarCyrill Gorcunov <gorcunov@openvz.org>
    Cc: Laurent Dufour <ldufour@linux.vnet.ibm.com>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    9f8bdb3f
swapfile.c 77.3 KB