• Stephane Eranian's avatar
    perf_events: Fix for transaction recovery in group_sched_in() · d7842da4
    Stephane Eranian authored
    This new version (see commit 8e5fc1a7) is much simpler and ensures that
    in case of error in group_sched_in() during event_sched_in(), the
    events up to the failed event go through regular event_sched_out().
    But the failed event and the remaining events in the group have their
    timings adjusted as if they had also gone through event_sched_in() and
    event_sched_out(). This ensures timing uniformity across all events in
    a group. This also takes care of the tstamp_stopped problem in case
    the group could never be scheduled. The tstamp_stopped is updated as
    if the event had actually run.
    
    With this patch, the following now reports correct time_enabled,
    in case the NMI watchdog is active:
    
    $ task -e unhalted_core_cycles,instructions_retired,baclears,baclears
    noploop 1
    noploop for 1 seconds
    
    0 unhalted_core_cycles (100.00% scaling, ena=997,552,872, run=0)
    0 instructions_retired (100.00% scaling, ena=997,552,872, run=0)
    0 baclears (100.00% scaling, ena=997,552,872, run=0)
    0 baclears (100.00% scaling, ena=997,552,872, run=0)
    
    And the older test case also works:
    
    $ task -einstructions_retired,baclears,baclears -e
    unhalted_core_cycles,baclears,baclears sleep 5
    
    1680885 instructions_retired (69.39% scaling, ena=950756, run=291006)
      10735 baclears (69.39% scaling, ena=950756, run=291006)
      10735 baclears (69.39% scaling, ena=950756, run=291006)
    
          0 unhalted_core_cycles (100.00% scaling, ena=817932, run=0)
          0 baclears (100.00% scaling, ena=817932, run=0)
          0 baclears (100.00% scaling, ena=817932, run=0)
    Signed-off-by: default avatarStephane Eranian <eranian@google.com>
    Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
    LKML-Reference: <4cbeeebc.8ee7d80a.5a28.0d5f@mx.google.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    d7842da4
perf_event.c 142 KB