• Luis R. Rodriguez's avatar
    Revert "mac80211: fix sw scan bracketing" · a0daa0e7
    Luis R. Rodriguez authored
    This reverts this commit. While in theory the change is
    correct the patch does not address current assumptions made
    by some drivers, one which is definitley affected is ath9k.
    
    Prior to this change the scan complete callback would be
    called after we returned to the home channel and configured
    the hardware RX filters. After this change we call the scan
    complete callback prior to both the hw config and the config
    filter. At least for ath9k this breaks quite a few assumptions
    on the callback, leading to disconnects to the AP after every scan
    making the driver pretty useless on STA mode. The goal behind
    this commit was to address the now understood spurious warnings
    from ath9k and mac80211_hwsim on scanning on two wiphys at the
    same time but we have now supressed these and will address this
    issue in the next kernel release.
    
    When fixing this for good next we must first review the other
    driver's dependence on this logic and perhaps consider removal
    of the scan complete callback all together.
    
    Cc: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    a0daa0e7
scan.c 20.3 KB