• Dominik Brodowski's avatar
    [PATCH] pcmcia: fix sharing IRQs and request_irq without IRQ_HANDLE_PRESENT · a1b274fb
    Dominik Brodowski authored
    Debugging and description from: Noah Misch <noah@cs.caltech.edu>
    
    When a driver calls pcmcia_request_irq with IRQ_HANDLE_PRESENT unset, it looks
    for an open IRQ by request_irq()ing with a dummy handler and NULL dev_info.
    free_irq uses dev_info as a key for identifying the handler to free among
    those sharing an IRQ, so request_irq returns -EINVAL if dev_info is NULL and
    the IRQ may be shared.  That unknown error code is the -EINVAL.
    
    It looks like only pcnet_cs and axnet_cs are affected.  Most other drivers let
    pcmcia_request_irq install their interrupt handlers.  sym53c500_cs requests
    its IRQ manually, but it cannot share an IRQ.
    
    The appended patch changes pcmcia_request_irq to pass an arbitrary, unique,
    non-NULL dev_info with the dummy handler.
    Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    a1b274fb
pcmcia_resource.c 25 KB