• Arnd Bergmann's avatar
    x86: kvm: avoid constant-conversion warning · a6a6d3b1
    Arnd Bergmann authored
    clang finds a contruct suspicious that converts an unsigned
    character to a signed integer and back, causing an overflow:
    
    arch/x86/kvm/mmu.c:4605:39: error: implicit conversion from 'int' to 'u8' (aka 'unsigned char') changes value from -205 to 51 [-Werror,-Wconstant-conversion]
                    u8 wf = (pfec & PFERR_WRITE_MASK) ? ~w : 0;
                       ~~                               ^~
    arch/x86/kvm/mmu.c:4607:38: error: implicit conversion from 'int' to 'u8' (aka 'unsigned char') changes value from -241 to 15 [-Werror,-Wconstant-conversion]
                    u8 uf = (pfec & PFERR_USER_MASK) ? ~u : 0;
                       ~~                              ^~
    arch/x86/kvm/mmu.c:4609:39: error: implicit conversion from 'int' to 'u8' (aka 'unsigned char') changes value from -171 to 85 [-Werror,-Wconstant-conversion]
                    u8 ff = (pfec & PFERR_FETCH_MASK) ? ~x : 0;
                       ~~                               ^~
    
    Add an explicit cast to tell clang that everything works as
    intended here.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Link: https://github.com/ClangBuiltLinux/linux/issues/95Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    a6a6d3b1
mmu.c 160 KB