• KarimAllah Ahmed's avatar
    x86/kexec: prepend elfcorehdr instead of appending it to the crash-kernel command-line. · a846f479
    KarimAllah Ahmed authored
    Any parameter passed after '--' in the kernel command-line will not be
    parsed by the kernel at all, instead it will be passed directly to init
    process.
    
    Currently the kernel appends elfcorehdr=<paddr> to the cmdline passed from
    kexec load, and if this command-line is used to pass parameters to init
    process this means that 'elfcorehdr' will not be parsed as a kernel
    parameter at all which will be a problem for vmcore subsystem since it
    will know nothing about the location of the ELF structure!
    
    Prepending 'elfcorehdr' instead of appending it fixes this problem since
    it ensures that it always comes before '--' and so it's always parsed as a
    kernel command-line parameter.
    
    Even with this patch things can still go wrong if 'CONFIG_CMDLINE' was
    also used to embedd a command-line to the crash dump kernel and this
    command-line contains '--' since the current behavior of the kernel is to
    actually append the boot loader command-line to the embedded command-line.
    Signed-off-by: default avatarKarimAllah Ahmed <karahmed@amazon.de>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Acked-by: default avatarVivek Goyal <vgoyal@redhat.com>
    Cc: Haren Myneni <hbabu@us.ibm.com>
    Cc: Eric Biederman <ebiederm@xmission.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    a846f479
kexec-bzimage64.c 15.2 KB