• Michal Hocko's avatar
    mm: throttle show_mem() from warn_alloc() · aa187507
    Michal Hocko authored
    Tetsuo has been stressing OOM killer path with many parallel allocation
    requests when he has noticed that it is not all that hard to swamp
    kernel logs with warn_alloc messages caused by allocation stalls.  Even
    though the allocation stall message is triggered only once in 10s there
    might be many different tasks hitting it roughly around the same time.
    
    A big part of the output is show_mem() which can generate a lot of
    output even on a small machines.  There is no reason to show the state
    of memory counter for each allocation stall, especially when multiple of
    them are reported in a short time period.  Chances are that not much has
    changed since the last report.  This patch simply rate limits show_mem
    called from warn_alloc to only dump something once per second.  This
    should be enough to give us a clue why an allocation might be stalling
    while burst of warnings will not swamp log with too much data.
    
    While we are at it, extract all the show_mem related handling (filters)
    into a separate function warn_alloc_show_mem.  This will make the code
    cleaner and as a bonus point we can distinguish which part of warn_alloc
    got throttled due to rate limiting as ___ratelimit dumps the caller.
    
    [akpm@linux-foundation.org: reduce scope of the ratelimit_states]
    Link: http://lkml.kernel.org/r/20161215101510.9030-1-mhocko@kernel.orgSigned-off-by: default avatarMichal Hocko <mhocko@suse.com>
    Reported-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    aa187507
page_alloc.c 204 KB