• Vaibhav Gupta's avatar
    fbdev: via-core: use generic power management · ab5fe88a
    Vaibhav Gupta authored
    Drivers should do only device-specific jobs. But in general, drivers using
    legacy PCI PM framework for .suspend()/.resume() have to manage many PCI
    PM-related tasks themselves which can be done by PCI Core itself. This
    brings extra load on the driver and it directly calls PCI helper functions
    to handle them.
    
    Switch to the new generic framework by updating function signatures and
    define a "struct dev_pm_ops" variable to bind PM callbacks.
    
    The via_suspend() is designed to function only in the case of Suspend.
    Thus, the code checked for "if (state.event != PM_EVENT_SUSPEND)". This is
    because, in the legacy framework, this callback was invoked even in the
    event of Freeze and Hibernate. Hence, added the load of unnecessary
    function-calls.
    
    The goal can be achieved by binding the callback with only
    "via_pm_ops.suspend" in the new framework. This also avoids the step of
    checking "if (state.event != PM_EVENT_SUSPEND)" every time the callback is
    invoked.
    Signed-off-by: default avatarVaibhav Gupta <vaibhavgupta40@gmail.com>
    Cc: Bjorn Helgaas <helgaas@kernel.org>
    Cc: Bjorn Helgaas <bhelgaas@google.com>
    Cc: Bjorn Helgaas <bjorn@helgaas.com>
    Cc: Vaibhav Gupta <vaibhav.varodek@gmail.com>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Russell King <linux@armlinux.org.uk>
    Cc: Andres Salomon <dilinger@queued.net>
    CC: Antonino Daplas <adaplas@gmail.com>
    Cc: Shuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200819185654.151170-4-vaibhavgupta40@gmail.com
    ab5fe88a
via-core.c 18.8 KB