• Eric Dumazet's avatar
    r8169: fix rx checksum offload · adea1ac7
    Eric Dumazet authored
    While porting GRO to r8169, I found this driver has a bug in its rx
    path.
    
    All skbs given to network stack had their ip_summed set to
    CHECKSUM_NONE, while hardware said they had correct TCP/UDP checksums.
    
    The reason is driver sets skb->ip_summed on the original skb before the
    copy eventually done by copybreak. The fresh skb gets the ip_summed =
    CHECKSUM_NONE value, forcing network stack to recompute checksum, and
    preventing my GRO patch to work.
    
    Fix is to make the ip_summed setting after skb copy.
    
    Note : rx_copybreak current value is 16383, so all frames are copied...
    Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
    Acked-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    adea1ac7
r8169.c 119 KB