• Linus Torvalds's avatar
    sysrq: don't depend on weak undefined arrays to have an address that compares as NULL · adf96e6f
    Linus Torvalds authored
    When taking an address of an extern array, gcc quite naturally should be
    able to say "an address of an object can never be NULL" and just
    optimize away the test entirely.
    
    However, the new alternate sysrq reset code (commit 154b7a48:
    "Input: sysrq - allow specifying alternate reset sequence") did exactly
    that, and declared platform_sysrq_reset_seq[] as a weak array, and
    expecting that testing the address of the array would show whether it
    actually got linked against something or not.
    
    And that doesn't work with all gcc versions.  Clearly it works with
    *some* versions of gcc, and maybe it's even supposed to work, but it
    really is a very fragile concept.
    
    So instead of testing the address of the weak variable, just create a
    weak instance of that array that is empty.  If some platform then has a
    real platform_sysrq_reset_seq[] that overrides our weak one, the linker
    will switch to that one, and it all works without any run-time
    conditionals at all.
    Reported-by: default avatarDave Airlie <airlied@gmail.com>
    Cc: David Howells <dhowells@redhat.com>
    Cc: Russell King <rmk+kernel@arm.linux.org.uk>
    Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Acked-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    adf96e6f
sysrq.c 23.7 KB