• Navid Emamdoost's avatar
    affs: fix a memory leak in affs_remount · 450c3d41
    Navid Emamdoost authored
    In affs_remount if data is provided it is duplicated into new_opts.  The
    allocated memory for new_opts is only released if parse_options fails.
    
    There's a bit of history behind new_options, originally there was
    save/replace options on the VFS layer so the 'data' passed must not
    change (thus strdup), this got cleaned up in later patches. But not
    completely.
    
    There's no reason to do the strdup in cases where the filesystem does
    not need to reuse the 'data' again, because strsep would modify it
    directly.
    
    Fixes: c8f33d0b ("affs: kstrdup() memory handling")
    Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
    [ update changelog ]
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    450c3d41
super.c 16.7 KB