• Douglas Anderson's avatar
    scripts/get_maintainer.pl: deprioritize old Fixes: addresses · 0ef82fce
    Douglas Anderson authored
    Recently, I found that get_maintainer was causing me to send emails to
    the old addresses for maintainers.  Since I usually just trust the
    output of get_maintainer to know the right email address, I didn't even
    look carefully and fired off two patch series that went to the wrong
    place.  Oops.
    
    The problem was introduced recently when trying to add signatures from
    Fixes.  The problem was that these email addresses were added too early
    in the process of compiling our list of places to send.  Things added to
    the list earlier are considered more canonical and when we later added
    maintainer entries we ended up deduplicating to the old address.
    
    Here are two examples using mainline commits (to make it easier to
    replicate) for the two maintainers that I messed up recently:
    
      $ git format-patch d8549bcd~..d8549bcd
      $ ./scripts/get_maintainer.pl 0001-clk-Add-clk_hw*.patch | grep Boyd
      Stephen Boyd <sboyd@codeaurora.org>...
    
      $ git format-patch 6d1238aa~..6d1238aa
      $ ./scripts/get_maintainer.pl 0001-arm64-dts-qcom-qcs404*.patch | grep Andy
      Andy Gross <andy.gross@linaro.org>
    
    Let's move the adding of addresses from Fixes: to the end since the
    email addresses from these are much more likely to be older.
    
    After this patch the above examples get the right addresses for the two
    examples.
    
    Link: http://lkml.kernel.org/r/20200127095001.1.I41fba9f33590bfd92cd01960161d8384268c6569@changeid
    Fixes: 2f5bd343 ("scripts/get_maintainer.pl: add signatures from Fixes: <badcommit> lines in commit message")
    Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
    Acked-by: default avatarJoe Perches <joe@perches.com>
    Cc: Stephen Boyd <sboyd@kernel.org>
    Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
    Cc: Andy Gross <agross@kernel.org>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Dan Carpenter <dan.carpenter@oracle.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    0ef82fce
get_maintainer.pl 66.6 KB