• Ingo Molnar's avatar
    x86/fpu: Initialize fpregs in fpu__init_cpu_generic() · b1276c48
    Ingo Molnar authored
    FPU fpregs do not get initialized during bootup on secondary CPUs,
    on non-xsave capable CPUs.
    
    For example on one of my systems, the secondary CPU has this FPU
    state on bootup:
    
    	x86: Booting SMP configuration:
    	.... node  #0, CPUs:      #1
    	x86/fpu ######################
    	x86/fpu # FPU register dump on CPU#1:
    	x86/fpu # ... CWD: ffff0040
    	x86/fpu # ... SWD: ffff0000
    	x86/fpu # ... TWD: ffff555a
    	x86/fpu # ... FIP: 00000000
    	x86/fpu # ... FCS: 00000000
    	x86/fpu # ... FOO: 00000000
    	x86/fpu # ... FOS: ffff0000
    	x86/fpu # ... FP0: 02 57 00 00 00 00 00 00 ff ff
    	x86/fpu # ... FP1: 1b e2 00 00 00 00 00 00 ff ff
    	x86/fpu # ... FP2: 00 00 00 00 00 00 00 00 00 00
    	x86/fpu # ... FP3: 00 00 00 00 00 00 00 00 00 00
    	x86/fpu # ... FP4: 00 00 00 00 00 00 00 00 00 00
    	x86/fpu # ... FP5: 00 00 00 00 00 00 00 00 00 00
    	x86/fpu # ... FP6: 00 00 00 00 00 00 00 00 00 00
    	x86/fpu # ... FP7: 00 00 00 00 00 00 00 00 00 00
    	x86/fpu # ...  SW: dadadada
    	x86/fpu ######################
    
    Note how CWD and TWD are off their usual init state (0x037f and 0xffff),
    and how FP0 and FP1 has non-zero content.
    
    This is normally not a problem, because any user-space FPU state
    is initalized properly - but it can complicate the use of FPU
    instructions in kernel code via kernel_fpu_begin()/end(): if
    the FPU using code does not initialize registers itself, it
    might generate spurious exceptions depending on which CPU it
    executes on.
    
    Fix this by initializing the x87 state via the FNINIT instruction.
    
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: Fenghua Yu <fenghua.yu@intel.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    b1276c48
init.c 7.09 KB