• Mikulas Patocka's avatar
    xfs: don't update mtime on COW faults · b17164e2
    Mikulas Patocka authored
    When running in a dax mode, if the user maps a page with MAP_PRIVATE and
    PROT_WRITE, the xfs filesystem would incorrectly update ctime and mtime
    when the user hits a COW fault.
    
    This breaks building of the Linux kernel.  How to reproduce:
    
     1. extract the Linux kernel tree on dax-mounted xfs filesystem
     2. run make clean
     3. run make -j12
     4. run make -j12
    
    at step 4, make would incorrectly rebuild the whole kernel (although it
    was already built in step 3).
    
    The reason for the breakage is that almost all object files depend on
    objtool.  When we run objtool, it takes COW page fault on its .data
    section, and these faults will incorrectly update the timestamp of the
    objtool binary.  The updated timestamp causes make to rebuild the whole
    tree.
    Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    b17164e2
xfs_file.c 34.8 KB