• Peter Staubach's avatar
    [PATCH] fix deadlock in ext2 · b2f49033
    Peter Staubach authored
    Fix a deadlock possible in the ext2 file system implementation.  This
    deadlock occurs when a file is removed from an ext2 file system which was
    mounted with the "sync" mount option.
    
    The problem is that ext2_xattr_delete_inode() was invoking the routine,
    sync_dirty_buffer(), using a buffer head which was previously locked via
    lock_buffer().  The first thing that sync_dirty_buffer() does is to lock
    the buffer head that it was passed.  It does this via lock_buffer().  Oops.
    
    The solution is to unlock the buffer head in ext2_xattr_delete_inode()
    before invoking sync_dirty_buffer().  This makes the code in
    ext2_xattr_delete_inode() obey the same locking rules as all other callers
    of sync_dirty_buffer() in the ext2 file system implementation.
    Signed-off-by: default avatarPeter Staubach <staubach@redhat.com>
    Cc: <stable@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    b2f49033
xattr.c 28.2 KB