• Joel Fernandes (Google)'s avatar
    mm: emit tracepoint when RSS changes · b3d1411b
    Joel Fernandes (Google) authored
    Useful to track how RSS is changing per TGID to detect spikes in RSS and
    memory hogs.  Several Android teams have been using this patch in
    various kernel trees for half a year now.  Many reported to me it is
    really useful so I'm posting it upstream.
    
    Initial patch developed by Tim Murray.  Changes I made from original
    patch: o Prevent any additional space consumed by mm_struct.
    
    Regarding the fact that the RSS may change too often thus flooding the
    traces - note that, there is some "hysterisis" with this already.  That
    is - We update the counter only if we receive 64 page faults due to
    SPLIT_RSS_ACCOUNTING.  However, during zapping or copying of pte range,
    the RSS is updated immediately which can become noisy/flooding.  In a
    previous discussion, we agreed that BPF or ftrace can be used to rate
    limit the signal if this becomes an issue.
    
    Also note that I added wrappers to trace_rss_stat to prevent compiler
    errors where linux/mm.h is included from tracing code, causing errors
    such as:
    
        CC      kernel/trace/power-traces.o
      In file included from ./include/trace/define_trace.h:102,
                       from ./include/trace/events/kmem.h:342,
                       from ./include/linux/mm.h:31,
                       from ./include/linux/ring_buffer.h:5,
                       from ./include/linux/trace_events.h:6,
                       from ./include/trace/events/power.h:12,
                       from kernel/trace/power-traces.c:15:
      ./include/trace/trace_events.h:113:22: error: field `ent' has incomplete type
         struct trace_entry ent;    \
    
    Link: http://lore.kernel.org/r/20190903200905.198642-1-joel@joelfernandes.org
    Link: http://lkml.kernel.org/r/20191001172817.234886-1-joel@joelfernandes.orgCo-developed-by: default avatarTim Murray <timmurray@google.com>
    Signed-off-by: default avatarTim Murray <timmurray@google.com>
    Signed-off-by: default avatarJoel Fernandes (Google) <joel@joelfernandes.org>
    Acked-by: default avatarMichal Hocko <mhocko@suse.com>
    Cc: Carmen Jackson <carmenjackson@google.com>
    Cc: Mayank Gupta <mayankgupta@google.com>
    Cc: Daniel Colascione <dancol@google.com>
    Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
    Cc: Minchan Kim <minchan@kernel.org>
    Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Cc: Jerome Glisse <jglisse@redhat.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Ralph Campbell <rcampbell@nvidia.com>
    Cc: Vlastimil Babka <vbabka@suse.cz>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    b3d1411b
kmem.h 7.73 KB