• Dave Chinner's avatar
    xfs: btree block LSN escaping to disk uninitialised · b58fa554
    Dave Chinner authored
    When testing LSN ordering code for v5 superblocks, it was discovered
    that the the LSN embedded in the generic btree blocks was
    occasionally uninitialised. These values didn't get written to disk
    by metadata writeback - they got written by previous transactions in
    log recovery.
    
    The issue is here that the when the block is first allocated and
    initialised, the LSN field was not initialised - it gets overwritten
    before IO is issued on the buffer - but the value that is logged by
    transactions that modify the header before it is written to disk
    (and initialised) contain garbage. Hence the first recovery of the
    buffer will stamp garbage into the LSN field, and that can cause
    subsequent transactions to not replay correctly.
    
    The fix is simply to initialise the bb_lsn field to zero when we
    initialise the block for the first time.
    Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
    Reviewed-by: default avatarMark Tinguely <tinguely@sgi.com>
    Signed-off-by: default avatarBen Myers <bpm@sgi.com>
    b58fa554
xfs_btree.c 99.8 KB