• Chris Wilson's avatar
    drm/i915/sdvo: Poll command status 5 times without delay on read · b5c616a7
    Chris Wilson authored
    The documentation says that an SDVO command takes a maximum of 15us to be
    processed by the device, and that it is sufficient to read the status byte
    3 times (whilst the command is still in the PENDING state) for the driver
    to be confident that sufficient time has elapsed.
    
    We err on the safe side and try 5 times before giving up.
    
    The only question that remains: was the old behaviour derived by
    experiments with real hardware?
    
    A look into the murky history of UMS, implies that the behaviour was
    accidental and the current retry mechanism was solely designed to catch
    the status byte indicating PENDING with no reference to hardware
    behaviour. (commit ac9181c014638dbeb334b40b4029d0ccb2b7a0fc in
    xf86-video-intel)
    Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    b5c616a7
intel_sdvo.c 80 KB