• Arnd Bergmann's avatar
    pwm: meson: Handle unknown ID values · 2fbc487d
    Arnd Bergmann authored
    When building with -Wmaybe-uninitialized, we get a couple of harmless
    warnings about three functions in this new driver that don't look
    safe to the compiler:
    
    drivers/pwm/pwm-meson.c: In function 'meson_pwm_get_state':
    drivers/pwm/pwm-meson.c:355:26: error: 'mask' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    drivers/pwm/pwm-meson.c: In function 'meson_pwm_disable':
    drivers/pwm/pwm-meson.c:263:13: error: 'enable' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    drivers/pwm/pwm-meson.c: In function 'meson_pwm_apply':
    drivers/pwm/pwm-meson.c:231:13: error: 'clk_shift' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    drivers/pwm/pwm-meson.c:231:36: error: 'enable' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    drivers/pwm/pwm-meson.c:231:24: error: 'clk_enable' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    Specifically, if we have a device with an ID other than 0 or 1,
    this would result in undefined behavior. This is currently not
    possible, but the compiler cannot be expected to know this.
    
    This patch adds a 'default' clause to let the compiler know
    what to do instead, which shuts up the warning and makes the
    code slightly more resiliant in case it gets extended to other
    identifiers.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
    Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
    2fbc487d
pwm-meson.c 13.4 KB