• Arnd Bergmann's avatar
    drm/nouveau: hide gcc-4.9 -Wmaybe-uninitialized · b74c0a99
    Arnd Bergmann authored
    gcc-4.9 notices that the validate_init() function returns unintialized
    data when called with a zero 'nr_buffers' argument, when called with the
    -Wmaybe-uninitialized flag:
    
    drivers/gpu/drm/nouveau/nouveau_gem.c: In function ‘validate_init.isra.6’:
    drivers/gpu/drm/nouveau/nouveau_gem.c:457:5: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    However, the only caller of this function always passes a nonzero
    argument, and gcc-6 is clever enough to take this into account and
    not warn about it any more.
    
    Adding an explicit initialization to -EINVAL here is correct even if
    the caller changed, and it avoids the warning on gcc-4.9 as well.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-By: default avatarKarol Herbst <karolherbst@gmail.com>
    Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
    b74c0a99
nouveau_gem.c 23.1 KB