• Andrew Morton's avatar
    x86: arch/x86/kernel/cpu/mcheck/ checkpatch fixes · b912a1c7
    Andrew Morton authored
    #40: FILE: arch/x86/kernel/cpu/mcheck/k7.c:46:
    +				snprintf (misc, 20, "[%08x%08x]", ahigh, alow);
    
    WARNING: line over 80 characters
    #45: FILE: arch/x86/kernel/cpu/mcheck/k7.c:50:
    +				snprintf (addr, 24, " at %08x%08x", ahigh, alow);
    
    WARNING: no space between function name and open parenthesis '('
    #45: FILE: arch/x86/kernel/cpu/mcheck/k7.c:50:
    +				snprintf (addr, 24, " at %08x%08x", ahigh, alow);
    
    WARNING: no space between function name and open parenthesis '('
    #48: FILE: arch/x86/kernel/cpu/mcheck/k7.c:52:
    +			printk (KERN_EMERG "CPU %d: Bank %d: %08x%08x%s%s\n",
    
    WARNING: no space between function name and open parenthesis '('
    #65: FILE: arch/x86/kernel/cpu/mcheck/p4.c:161:
    +		printk (KERN_DEBUG "CPU %d: EIP: %08x EFLAGS: %08x\n"
    
    WARNING: no space between function name and open parenthesis '('
    #88: FILE: arch/x86/kernel/cpu/mcheck/p4.c:182:
    +				snprintf (misc, 20, "[%08x%08x]", ahigh, alow);
    
    WARNING: line over 80 characters
    #93: FILE: arch/x86/kernel/cpu/mcheck/p4.c:186:
    +				snprintf (addr, 24, " at %08x%08x", ahigh, alow);
    
    WARNING: no space between function name and open parenthesis '('
    #93: FILE: arch/x86/kernel/cpu/mcheck/p4.c:186:
    +				snprintf (addr, 24, " at %08x%08x", ahigh, alow);
    
    WARNING: no space between function name and open parenthesis '('
    #96: FILE: arch/x86/kernel/cpu/mcheck/p4.c:188:
    +			printk (KERN_EMERG "CPU %d: Bank %d: %08x%08x%s%s\n",
    
    WARNING: no space between function name and open parenthesis '('
    #120: FILE: arch/x86/kernel/cpu/mcheck/p6.c:46:
    +				snprintf (misc, 20, "[%08x%08x]", ahigh, alow);
    
    WARNING: line over 80 characters
    #125: FILE: arch/x86/kernel/cpu/mcheck/p6.c:50:
    +				snprintf (addr, 24, " at %08x%08x", ahigh, alow);
    
    WARNING: no space between function name and open parenthesis '('
    #125: FILE: arch/x86/kernel/cpu/mcheck/p6.c:50:
    +				snprintf (addr, 24, " at %08x%08x", ahigh, alow);
    
    WARNING: no space between function name and open parenthesis '('
    #128: FILE: arch/x86/kernel/cpu/mcheck/p6.c:52:
    +			printk (KERN_EMERG "CPU %d: Bank %d: %08x%08x%s%s\n",
    
    total: 0 errors, 13 warnings, 100 lines checked
    
    Your patch has style problems, please review.  If any of these errors
    are false positives report them to the maintainer, see
    CHECKPATCH in MAINTAINERS.
    
    Please run checkpatch prior to sending patches
    
    Cc: Min Zhang <mzhang@mvista.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    b912a1c7
p6.c 3.03 KB