• Mauro Carvalho Chehab's avatar
    [media] dib8000: rename dib8000_attach to dib8000_init · b9bc7d59
    Mauro Carvalho Chehab authored
    Well, what we call as "foo_attach" is the method that should
    be called by the dvb_attach() macro.
    
    It should be noticed that the name "dvb_attach" is really a
    bad name and don't express what it does.
    
    dvb_attach() basically does three things, if the frontend is
    compiled as a module:
    - It lookups for the module that it is known to have the
      given symbol name and requests such module;
    - It increments the module usage (anonymously - so lsmod
      doesn't print who loaded the module);
    - after loading the module, it runs the function associated
      with the dynamic symbol.
    
    When compiled as builtin, it just calls the function given to it.
    
    As dvb_attach() increments refcount, it can't be (easily)
    called more than once for the same module, or the kernel
    will deny to remove the module, because refcount will never
    be zeroed.
    
    In other words, the function name given to dvb_attach()
    should be one single symbol that will always be called
    before any other function on that module to be used.
    
    For almost all DVB frontends, there's just one function,
    but, on dib8000, there are several exported symbols.
    
    We need to get rid of all those direct calls, because they
    cause compilation breakages when bridge is builtin and
    frontend is module, we'll need to add a new function that
    will be the first one to be called, whatever initialization
    is needed.
    
    So, let's rename this function, in order to prepare for
    a next patch that will add a new attach() function that
    will be the only one exported by this module.
    Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
    b9bc7d59
dib8000.c 133 KB