• Lorenzo Pieralisi's avatar
    ARM: 8293/1: kernel: fix pci_mmap_page_range() offset calculation · 415ae101
    Lorenzo Pieralisi authored
    The pci_mmap_page_range() API should be written to expect offset
    values representing PCI memory resource addresses as seen by user
    space, through the pci_resource_to_user() API.
    
    ARM relies on the standard implementation of pci_resource_to_user()
    which actually is an identity map and exports to user space
    PCI memory resources as they are stored in PCI devices resources
    structures, which represent CPU physical addresses (fixed-up using
    BUS to CPU address conversions) not PCI bus addresses.
    
    Therefore, on ARM platforms where the mapping between CPU and BUS
    address is not a 1:1 the current pci_mmap_page_range() implementation is
    erroneous, in that an additional shift is applied to an already fixed-up
    offset passed from userspace.
    
    Hence, this patch removes the mem_offset from the pgoff calculation
    since the offset as passed from user space already represents the CPU
    physical address corresponding to the resource to be mapped, ie no
    additional offset should be applied.
    
    Cc: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
    Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
    415ae101
bios32.c 16.3 KB