• Jim Keniston's avatar
    [PATCH] kprobes: fix handling of simultaneous probe hit/unregister · bce06494
    Jim Keniston authored
    This patch fixes a bug in kprobes's handling of a corner case on i386 and
    x86_64.  On an SMP system, if one CPU unregisters a kprobe just after
    another CPU hits that probepoint, kprobe_handler() on the latter CPU sees
    that the kprobe has been unregistered, and attempts to let the CPU continue
    as if the probepoint hadn't been hit.  The bug is that on i386 and x86_64,
    we were neglecting to set the IP back to the beginning of the probed
    instruction.  This could cause an oops or crash.
    
    This bug doesn't exist on ppc64 and ia64, where a breakpoint instruction
    leaves the IP pointing to the beginning of the instruction.  I don't know
    about sparc64.  (Dave, could you please advise?)
    
    This fix has been tested on i386 and x86_64 SMP systems.  To reproduce the
    problem, set one CPU to work registering and unregistering a kprobe
    repeatedly, and another CPU pounding the probepoint in a tight loop.
    Acked-by: default avatarPrasanna S Panchamukhi <prasanna@in.ibm.com>
    Signed-off-by: default avatarJim Keniston <jkenisto@us.ibm.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    bce06494
kprobes.c 20.4 KB