• Michael Clark's avatar
    MIPS: fix truncation in __cmpxchg_small for short values · 94ee12b5
    Michael Clark authored
    __cmpxchg_small erroneously uses u8 for load comparison which can
    be either char or short. This patch changes the local variable to
    u32 which is sufficiently sized, as the loaded value is already
    masked and shifted appropriately. Using an integer size avoids
    any unnecessary canonicalization from use of non native widths.
    
    This patch is part of a series that adapts the MIPS small word
    atomics code for xchg and cmpxchg on short and char to RISC-V.
    
    Cc: RISC-V Patches <patches@groups.riscv.org>
    Cc: Linux RISC-V <linux-riscv@lists.infradead.org>
    Cc: Linux MIPS <linux-mips@linux-mips.org>
    Signed-off-by: default avatarMichael Clark <michaeljclark@mac.com>
    [paul.burton@mips.com:
      - Fix varialble typo per Jonas Gorski.
      - Consolidate load variable with other declarations.]
    Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
    Fixes: 3ba7f44d ("MIPS: cmpxchg: Implement 1 byte & 2 byte cmpxchg()")
    Cc: stable@vger.kernel.org # v4.13+
    94ee12b5
cmpxchg.c 2.9 KB