• Jiri Slaby's avatar
    Char: nozomi, set tty->driver_data appropriately · bf9c1fca
    Jiri Slaby authored
    Sorry, one more fix, this one depends on the other, so this is rather 2/2.
    --
    
    tty->driver_data is used all over the code, but never set. This
    results in oopses like:
    BUG: unable to handle kernel NULL pointer dereference at 0000000000000130
    IP: [<ffffffff814a0040>] mutex_lock+0x10/0x40
    ...
    Pid: 2157, comm: modem-manager Not tainted 2.6.34.1-0.1-desktop #1 2768DR7/2768DR7
    RIP: 0010:[<ffffffff814a0040>]  [<ffffffff814a0040>] mutex_lock+0x10/0x40
    RSP: 0018:ffff88007b16fa50  EFLAGS: 00010286
    RAX: 0000000000000000 RBX: 0000000000000130 RCX: 0000000000000003
    RDX: 0000000000000003 RSI: 0000000000000286 RDI: 0000000000000130
    RBP: 0000000000001000 R08: 0000000000000000 R09: 0000000000000000
    R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000130
    R13: 0000000000000001 R14: 0000000000000000 R15: ffff88007b16feb4
    ...
    Call Trace:
     [<ffffffffa077690d>] ntty_write_room+0x4d/0x90 [nozomi]
    ...
    
    Set tty->driver_data to the computed port in .install to not recompute it in
    every place where needed. Switch .open to use driver_data too.
    Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
    Cc: Alan Cox <alan@linux.intel.com>
    Cc: stable <stable@kernel.org> [.34, .35]
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    
    bf9c1fca
nozomi.c 49.1 KB