• Robert Foss's avatar
    cdc-wdm: Clear read pipeline in case of error · c1da59da
    Robert Foss authored
    Implemented queued response handling. This queue is processed every time the
    WDM_READ flag is cleared.
    
    In case of a read error, userspace may not actually read the data, since the
    driver returns an error through wdm_poll. After this, the underlying device may
    attempt to send us more data, but the queue is not processed. While userspace is
    also blocked, because the read error is never cleared.
    
    After this patch, we proactively process the queue on a read error. If there was
    an outstanding response to handle, that will clear the error (or go through the
    same logic again, if another read error occurs). If there was no outstanding
    response, this will bring the queue size back to 0, unblocking a future response
    from the underlying device.
    Signed-off-by: default avatarRobert Foss <robert.foss@collabora.com>
    Tested-by: default avatarRobert Foss <robert.foss@collabora.com>
    Acked-by: default avatarOliver Neukum <oneukum@suse.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    c1da59da
cdc-wdm.c 30 KB