• Sven Eckelmann's avatar
    batman-adv: Use successive sequence numbers for fragments · c2f7f0e7
    Sven Eckelmann authored
    The two fragments of an unicast packet must have successive sequence numbers to
    allow the receiver side to detect matching fragments and merge them again. The
    current implementation doesn't provide that property because a sequence of two
    atomic_inc_return may be interleaved with another sequence which also changes
    the variable.
    
    The access to the fragment sequence number pool has either to be protected by
    correct locking or it has to reserve two sequence numbers in a single fetch.
    The latter one can easily be done by increasing the value of the last used
    sequence number by 2 in a single step. The generated window of two currently
    unused sequence numbers can now be scattered across the two fragments.
    Reported-by: default avatarLinus Lüssing <linus.luessing@web.de>
    Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
    c2f7f0e7
unicast.c 8.83 KB