• Mauro Carvalho Chehab's avatar
    [media] dib0700: fix RC support on Hauppauge Nova-TD · c4018fa2
    Mauro Carvalho Chehab authored
    The RC support o Nova-TD is broken, as the RC endpoint there
    is an interrupt endpoint.
    
    That produces an ugly calltrace at the Kernel logs:
    
    	WARNING: CPU: 2 PID: 56 at drivers/usb/core/urb.c:450 usb_submit_urb+0x1fd/0x5c0()
    	usb 1-1.2: BOGUS urb xfer, pipe 3 != type 1
    	Modules linked in: rc_dib0700_rc5(OF) dvb_usb_dib0700(OF) dib9000(OF) dib8000(OF) dib7000m(OF) dib0090(OF) dib0070(OF) dib7000p(OF) dib3000mc(OF) dibx000_common(OF) dvb_usb(OF) rc_core(OF) snd_usb_audio snd_usbmidi_lib snd_hwdep snd_rawmidi snd_seq snd_seq_device snd_pcm snd_timer snd soundcore bnep bluetooth 6lowpan_iphc rfkill au0828(OF) xc5000(OF) au8522_dig(OF) au8522_common(OF) tveeprom(OF) dvb_core(OF) nouveau i915 mxm_wmi ttm i2c_algo_bit drm_kms_helper drm r8169 mii i2c_core video wmi [last unloaded: au0828]
    	CPU: 2 PID: 56 Comm: khubd Tainted: GF          O 3.14.2-200.fc20.x86_64 #1
    	Hardware name: SAMSUNG ELECTRONICS CO., LTD. 550P5C/550P7C/SAMSUNG_NP1234567890, BIOS P05ABI.016.130917.dg 09/17/2013
    	 0000000000000000 00000000610866bc ffff880223703860 ffffffff816eec92
    	 ffff8802237038a8 ffff880223703898 ffffffff8108a1bd ffff8800916a2180
    	 ffff8801d5b16000 0000000000000003 0000000000000003 0000000000000020
    	Call Trace:
    	 [<ffffffff816eec92>] dump_stack+0x45/0x56
    	 [<ffffffff8108a1bd>] warn_slowpath_common+0x7d/0xa0
    	 [<ffffffff8108a23c>] warn_slowpath_fmt+0x5c/0x80
    	 [<ffffffff814e3ebd>] usb_submit_urb+0x1fd/0x5c0
    	 [<ffffffffa0445925>] dib0700_rc_setup+0xb5/0x120 [dvb_usb_dib0700]
    	 [<ffffffffa0445a58>] dib0700_probe+0xc8/0x130 [dvb_usb_dib0700]
    	...
    
    Fix it by detecting if the endpoint is bulk or interrupt.
    
    Tested with both Hauppauge Nova-TD model 52009 (interrupt) and with a
    		 Prolink Pixelview SBTVD model PV-D231U (bulk).
    Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
    c4018fa2
dib0700.h 3.14 KB