• Hans de Goede's avatar
    ARM: dts: sun8i-q8-common: Do not set constraints on dc1sw regulator · dcf5341f
    Hans de Goede authored
    dc1sw is an on/off only regulator and as such it cannot have constraints.
    
    This is a limitation of the kernel regulator implementation which resolves
    supplies on the first regulator_get(), which is done after applying
    constraints, and applying the constrains will fail because it calls
    _regulator_get_voltage() and _regulator_do_set_voltage() both of which
    will fail on a switch regulator when there is no supply (yet).
    
    This causes registering of all axp22x regulators to fail with the
    following errors:
    
    [    1.395249] vcc-lcd: failed to get the current voltage(-22)
    [    1.405131] axp20x-regulator axp20x-regulator: Failed to register dc1sw
    [    1.412436] axp20x-regulator: probe of axp20x-regulator failed with error -22
    
    This commit removes the constrains on dc1sw / vcc-lcd fixing this problem
    note that dcdc1 itself is contrained to the exact same values, so this
    does not change anything.
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Signed-off-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
    dcf5341f
sun8i-q8-common.dtsi 4.58 KB