• Gustavo A. R. Silva's avatar
    platform/x86: thinkpad_acpi: Mark expected switch fall-throughs · c77c3577
    Gustavo A. R. Silva authored
    In preparation to enabling -Wimplicit-fallthrough, mark switch
    cases where we are expecting to fall through.
    
    This patch fixes the following warnings:
    
    drivers/platform/x86/thinkpad_acpi.c: In function ‘thermal_get_sensor’:
    drivers/platform/x86/thinkpad_acpi.c:6316:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
       if (idx >= 8 && idx <= 15) {
          ^
    drivers/platform/x86/thinkpad_acpi.c:6322:2: note: here
      case TPACPI_THERMAL_TPEC_8:
      ^~~~
    drivers/platform/x86/thinkpad_acpi.c: In function ‘hotkey_notify’:
    drivers/platform/x86/thinkpad_acpi.c:4208:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
        if (tp_features.hotkey_wlsw &&
           ^
    drivers/platform/x86/thinkpad_acpi.c:4216:3: note: here
       default:
       ^~~~~~~
    
    Warning level 3 was used: -Wimplicit-fallthrough=3
    
    Notice that, in this particular case, the code comments are modified
    in accordance with what GCC is expecting to find.
    
    This patch is part of the ongoing efforts to enable
    -Wimplicit-fallthrough.
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Reviewed-by: default avatarKees Cook <keescook@chromium.org>
    Acked-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
    Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
    c77c3577
thinkpad_acpi.c 265 KB