• John Stultz's avatar
    driver core: Fix driver_deferred_probe_check_state() logic · c8c43cee
    John Stultz authored
    driver_deferred_probe_check_state() has some uninituitive behavior.
    
    * From boot to late_initcall, it returns -EPROBE_DEFER
    
    * From late_initcall to the deferred_probe_timeout (if set)
      it returns -ENODEV
    
    * If the deferred_probe_timeout it set, after it fires, it
      returns -ETIMEDOUT
    
    This is a bit confusing, as its useful to have the function
    return -EPROBE_DEFER while the timeout is still running. This
    behavior has resulted in the somwhat duplicative
    driver_deferred_probe_check_state_continue() function being
    added.
    
    Thus this patch tries to improve the logic, so that it behaves
    as such:
    
    * If late_initcall has passed, and modules are not enabled
      it returns -ENODEV
    
    * If modules are enabled and deferred_probe_timeout is set,
      it returns -EPROBE_DEFER until the timeout, afterwhich it
      returns -ETIMEDOUT.
    
    * In all other cases, it returns -EPROBE_DEFER
    
    This will make the deferred_probe_timeout value much more
    functional, and will allow us to consolidate the
    driver_deferred_probe_check_state() and
    driver_deferred_probe_check_state_continue() logic in a later
    patch.
    
    Cc: linux-pm@vger.kernel.org
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Linus Walleij <linus.walleij@linaro.org>
    Cc: Thierry Reding <treding@nvidia.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Liam Girdwood <lgirdwood@gmail.com>
    Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
    Cc: Saravana Kannan <saravanak@google.com>
    Cc: Todd Kjos <tkjos@google.com>
    Cc: Len Brown <len.brown@intel.com>
    Cc: Pavel Machek <pavel@ucw.cz>
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Cc: Kevin Hilman <khilman@kernel.org>
    Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
    Cc: Rob Herring <robh@kernel.org>
    Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
    Link: https://lore.kernel.org/r/20200225050828.56458-2-john.stultz@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    c8c43cee
dd.c 32.9 KB