• Chris Wilson's avatar
    drm/i915: During shrink_all we only need to idle the GPU · c9c0f5ea
    Chris Wilson authored
    We can forgo an evict-everything here as the shrinker operation itself
    will unbind any vma as required. If we explicitly idle the GPU through a
    switch to the default context, we not only create a request in an
    illegal context (e.g. whilst shrinking during execbuf with a request
    already allocated), but switching to the default context will not free
    up the memory backing the active contexts - unless in the unlikely
    situation that context had already been closed (and just kept arrive by
    being the current context). The saving is near zero and the danger real.
    
    To compensate for the loss of the forced retire, add a couple of
    retire-requests to i915_gem_shirnk() - this should help free up any
    transitive cache from the requests.
    
    Note that the second retire_requests is for the benefit of the
    hand-rolled execlist ctx active tracking: We need to manually kick
    requests to get those unpinned again. Once that's fixed we can try to
    remove this again.
    Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    [danvet: Add summary of why we need a pile of retire_requests.]
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    c9c0f5ea
i915_gem_shrinker.c 10.2 KB