• James Morse's avatar
    arm64: Remove useless UAO IPI and describe how this gets enabled · c8b06e3f
    James Morse authored
    Since its introduction, the UAO enable call was broken, and useless.
    commit 2a6dcb2b ("arm64: cpufeature: Schedule enable() calls instead
    of calling them via IPI"), fixed the framework so that these calls
    are scheduled, so that they can modify PSTATE.
    
    Now it is just useless. Remove it. UAO is enabled by the code patching
    which causes get_user() and friends to use the 'ldtr' family of
    instructions. This relies on the PSTATE.UAO bit being set to match
    addr_limit, which we do in uao_thread_switch() called via __switch_to().
    
    All that is needed to enable UAO is patch the code, and call schedule().
    __apply_alternatives_multi_stop() calls stop_machine() when it modifies
    the kernel text to enable the alternatives, (including the UAO code in
    uao_thread_switch()). Once stop_machine() has finished __switch_to() is
    called to reschedule the original task, this causes PSTATE.UAO to be set
    appropriately. An explicit enable() call is not needed.
    Reported-by: default avatarVladimir Murzin <vladimir.murzin@arm.com>
    Signed-off-by: default avatarJames Morse <james.morse@arm.com>
    c8b06e3f
processor.h 4.68 KB