• Diego Calleja's avatar
    [LAPB]: Fix windowsize check · 558e10a5
    Diego Calleja authored
    In bug #6954, Norbert Reinartz reported the following issue:
    
    "Function lapb_setparms() in file net/lapb/lapb_iface.c checks if the given
    parameters are valid. If the given window size is in the range of 8 .. 127,
    lapb_setparms() fails and returns an error value of LAPB_INVALUE, even if bit
    LAPB_EXTENDED in parms->mode is set.
    If bit LAPB_EXTENDED in parms->mode is set and the window size is in the range
    of 8 .. 127, the first check "(parms->mode & LAPB_EXTENDED)" results true  and
    the second check "(parms->window < 1 || parms->window > 127)" results false.
    Both checks in conjunction result to false, thus the third check "(parms->window
    < 1 || parms->window > 7)" is done by fault.
    This third check results true, so that we leave lapb_setparms() by 'goto out_put'.
    Seems that this bug doesn't cause any problems, because lapb_setparms() isn't
    used to change the default values of LAPB. We are using kernel lapb in our
    software project and also change the default parameters of lapb, so we found
    this bug"
    
    He also pasted a fix, that I've transformated into a patch:
    Signed-off-by: default avatarDiego Calleja <diegocg@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    558e10a5
lapb_iface.c 9.03 KB