• Tony Luck's avatar
    x86/mm, x86/mce: Fix return type/value for memcpy_mcsafe() · cbf8b5a2
    Tony Luck authored
    Returning a 'bool' was very unpopular. Doubly so because the
    code was just wrong (returning zero for true, one for false;
    great for shell programming, not so good for C).
    
    Change return type to "int". Keep zero as the success indicator
    because it matches other similar code and people may be more
    comfortable writing:
    
    	if (memcpy_mcsafe(to, from, count)) {
    		printk("Sad panda, copy failed\n");
    		...
    	}
    
    Make the failure return value -EFAULT for now.
    
    Reported by: Mika Penttilä <mika.penttila@nextfour.com>
    Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: mika.penttila@nextfour.com
    Fixes: 92b0729c ("x86/mm, x86/mce: Add memcpy_mcsafe()")
    Link: http://lkml.kernel.org/r/695f14233fa7a54fcac4406c706d7fec228e3f4c.1457993040.git.tony.luck@intel.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    cbf8b5a2
memcpy_64.S 6.04 KB